Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add code cache support for SourceTextModule #31278

Merged
merged 1 commit into from
Jan 12, 2020
Merged

vm: add code cache support for SourceTextModule #31278

merged 1 commit into from
Jan 12, 2020

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jan 9, 2020

Fixes #31233

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Jan 9, 2020
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 9, 2020
@devsnek devsnek removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28327/

@devsnek
Copy link
Member Author

devsnek commented Jan 9, 2020

If you are reviewing this PR, please also go check out #30709. It has been open since late November and really needs reviews.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28330/

@Trott Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 11, 2020
@Trott
Copy link
Member

Trott commented Jan 11, 2020

@nodejs/vm

targos
targos reviewed Jan 11, 2020
View reviewed changes
doc/api/vm.md Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28367/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28407/

@devsnek
vm: add code cache support for SourceTextModule
b810e67 
PR-URL: nodejs#31278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@devsnek devsnek merged commit b810e67 into nodejs:master Jan 12, 2020
@devsnek devsnek deleted the vm-stm-code-cache branch January 12, 2020 22:44
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@devsnek @MylesBorins
vm: add code cache support for SourceTextModule
27564a4 
PR-URL: #31278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@devsnek @targos
vm: add code cache support for SourceTextModule
0aeb955 
PR-URL: nodejs#31278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 28, 2020
@devsnek @targos
vm: add code cache support for SourceTextModule
eda6665 
PR-URL: #31278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@targos targos targos left review comments

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
semver-minor PRs that contain new features and should be released in the next minor version. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow code caches to be created for modules
7 participants
@devsnek @nodejs-github-bot @Trott @jasnell @addaleax @targos @BridgeAR